Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a few simplified isinstance (ruff SIM101) #38817

Merged
merged 2 commits into from
Nov 3, 2024
Merged

a few simplified isinstance (ruff SIM101) #38817

merged 2 commits into from
Nov 3, 2024

Conversation

fchapoton
Copy link
Contributor

a few simplified calls of isinstance

following ruff SIM101

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

vincentmacri
vincentmacri reviewed Oct 16, 2024
View reviewed changes
Copy link
Contributor

@vincentmacri vincentmacri left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Before approving: is there a linter check you can enable to make sure future code uses isinstance correctly?

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 55a6097; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@fchapoton
Copy link
Contributor Author

yes, but but the ruff linter check has to wait that one fixes later the remaining 27 cases.

@vincentmacri
Copy link
Contributor

Thanks for the contribution!

@fchapoton
Copy link
Contributor Author

I think the failures are not related. I therefore set back to positive, as the merge was trivial.

@vbraun vbraun merged commit 6959ae2 into sagemath:develop Nov 3, 2024
15 of 22 checks passed
@fchapoton fchapoton deleted the ruffSIM101 branch November 4, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentmacri vincentmacri vincentmacri left review comments

Assignees
No one assigned
Labels
t: refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @vincentmacri @vbraun