add generic has_order() function #36806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscrim
requested changes
Dec 5, 2023
src/sage/groups/generic.py
Outdated
| n = n.factor() | ||
|
|
||
| G = P.parent() | ||
| if operation == '+': |
There was a problem hiding this comment.
I think it would be better to use operator.add and operator.mul than string comparisons. Although strings seem to be used elsewhere...
There was a problem hiding this comment.
On the long run, all of these ad-hoc interfaces should be replaced by a proper wrapper class (which is work in progress). For now, I'd stick to doing it the same way as the existing functions in this file...
yyyyx4
force-pushed
the
public/generic_has_order_function
branch
from
ebaa89c to
be14d9f
Compare
tscrim
requested changes
Dec 27, 2023
|
Documentation preview for this PR (built with commit 3e61e7d; changes) is ready! 🎉 |
|
Thank you! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 5, 2024
sagemathgh-36806: add generic has_order() function Currently there is `order_from_multiple()` for generic groups, but sometimes we really only want to know if the order equals a particular value (e.g., when sampling random elements to find a generating set of a group with known structure). This means the computation can be aborted earlier than when finding the exact order is required. In this patch we add such an optimized `has_order()` function as well as a convenience wrapper for elliptic-curve points. An example of the speedup can be found in one of the new doctests. URL: sagemath#36806 Reported by: Lorenz Panny Reviewer(s): Lorenz Panny, Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is
order_from_multiple()for generic groups, but sometimes we really only want to know if the order equals a particular value (e.g., when sampling random elements to find a generating set of a group with known structure). This means the computation can be aborted earlier than when finding the exact order is required.In this patch we add such an optimized
has_order()function as well as a convenience wrapper for elliptic-curve points. An example of the speedup can be found in one of the new doctests.