Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typographic typos #36388

Conversation

mantepse
Copy link
Collaborator

@mantepse mantepse commented Oct 2, 2023

Fix a few typographic typos in thematic_tutorials/tutorial-implementing-algebraic-structures: missing double backtick, missing underscore.

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Documentation preview for this PR (built with commit ad09d52; changes) is ready! 🎉

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise, LGTM.

@@ -319,7 +319,7 @@ Diagonal and Triangular Morphisms

We now illustrate how to specify that a given morphism is diagonal or triangular
with respect to some order on the basis, which means that the morphism is
invertible and `Sage` is able to compute the inverse morphism automatically.
invertible and Sage is able to compute the inverse morphism automatically.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we say Sage or Sagemath ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a single occurrence of SageMath throughout all the tutorials (and many occurrences of Sage), so I would stick with this or change it in a separate ticket.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification. I have no preference.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit 4699773 into sagemath:develop Oct 8, 2023
25 of 31 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Oct 8, 2023
@mantepse mantepse deleted the fix_typos/tutorial-implementing-algebraic-structures branch October 9, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants