Skip to content

using mute variables in combinat #36107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 27, 2023
Merged

using mute variables in combinat #36107

merged 4 commits into from
Aug 27, 2023

Conversation

@fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Aug 20, 2023

taking care of unused variables found by pylint in combinat

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

mkoeppe
mkoeppe reviewed Aug 20, 2023
View reviewed changes
mantepse
mantepse reviewed Aug 21, 2023
View reviewed changes
@fchapoton
Update sloane_functions.py
a0fd815 
using Partitions
dcoudert
dcoudert suggested changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise, LGTM.

@github-actions
Copy link

github-actions bot commented Aug 21, 2023

Documentation preview for this PR (built with commit 613a287; changes) is ready! 🎉

dcoudert
dcoudert approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fchapoton
Copy link
Contributor Author

fchapoton commented Aug 22, 2023

Merci. Je peux passer en positif, alors ?

@dcoudert
Copy link
Contributor

dcoudert commented Aug 22, 2023

I was waiting in case @mkoeppe or @mantepse had extra comments.

@vbraun vbraun merged commit 34c505e into sagemath:develop Aug 27, 2023
@fchapoton fchapoton deleted the mute_for_unused_vars_in_combi branch August 28, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@mkoeppe mkoeppe mkoeppe left review comments

@mantepse mantepse mantepse left review comments

@dcoudert dcoudert dcoudert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: combinatorics

Projects

None yet

Milestone

sage-10.2

Development

Successfully merging this pull request may close these issues.

5 participants

@fchapoton @dcoudert @mkoeppe @mantepse @vbraun