Skip to content

Commit 7f1d531

Browse files
author
Matthias Koeppe
committed
Suggested edits
1 parent 40bde9d commit 7f1d531

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

build/sage_bootstrap/creator.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -82,11 +82,10 @@ def heading(title, char='-'):
8282

8383
def _remove_files(self, files):
8484
"""
85-
Remove ``files`` from the package directory if they exist
85+
Remove ``files`` from the package directory if they exist.
8686
"""
8787
for file in files:
8888
try:
89-
# Remove this file, which would mark the package as a pip package.
9089
os.remove(os.path.join(self.path, file))
9190
except OSError:
9291
pass
@@ -125,7 +124,7 @@ def set_python_data_and_scripts(self, pypi_package_name=None, source='normal'):
125124
# 'pip' should be the only wheel package that has a custom spkg-install.in script.
126125
# Remove the script for all other wheel packages, to avoid errors when
127126
# switching from normal to wheel packages.
128-
self._remove_files(['spkg-build.in', 'spkg-install.in'])
127+
self._remove_files(['spkg-build.in', 'spkg-install.in', 'spkg-install'])
129128
elif source == 'pip':
130129
with open(os.path.join(self.path, 'requirements.txt'), 'w+') as f:
131130
f.write('{0}\n'.format(pypi_package_name))

src/doc/en/developer/packaging.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ the following source types:
9292

9393
- its version number is defined by the required file ``package-version.txt``;
9494

95-
- No build and install scripts are needed
95+
- no build and install scripts are needed
9696
(with one exception: the package :ref:`spkg_pip` installs itself from
9797
its wheel using a custom install script);
9898

0 commit comments

Comments
 (0)