Commit 54af5b3
Release Manager
gh-38964: Drinfeld Modules: Default to zero endomorphism in `.hom` and avoid inversion of zero endomorphism
This PR fixes #38953 and is inspired by the error raised in the issue:
- The main fix is to avoid sampling the zero element of the base field
in the test of `__invert__`, so that `phi.hom(a)` actually returns an
invertible morphism.
- However, the error raised in the issue named above was slightly
confusing, as the call of `phi.hom(K.zero())` does not return any
homomorphism: Since the codomain is not specified, it tries to find a
codomain via the `.velu`-method, but this only works if the given
element defines an isogeny, which `K.zero()` does not. Instead of
raising an error for this special case in `.hom`, it seems more robust
to default to the zero endomorphism of `self` instead.
- Also added the mention of `isog` in the `.velu`-method.
URL: #38964
Reported by: Sebastian A. Spindler
Reviewer(s): Xavier Caruso
File tree
2 files changed
+13
-3
lines changed- src/sage/rings/function_field/drinfeld_modules
2 files changed
+13
-3
lines changedLines changed: 9 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1855 | 1855 | | |
1856 | 1856 | | |
1857 | 1857 | | |
1858 | | - | |
| 1858 | + | |
1859 | 1859 | | |
1860 | 1860 | | |
1861 | 1861 | | |
| |||
2018 | 2018 | | |
2019 | 2019 | | |
2020 | 2020 | | |
| 2021 | + | |
| 2022 | + | |
| 2023 | + | |
| 2024 | + | |
| 2025 | + | |
| 2026 | + | |
2021 | 2027 | | |
2022 | 2028 | | |
2023 | 2029 | | |
2024 | 2030 | | |
2025 | 2031 | | |
| 2032 | + | |
| 2033 | + | |
2026 | 2034 | | |
2027 | 2035 | | |
2028 | 2036 | | |
| |||
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
536 | 536 | | |
537 | 537 | | |
538 | 538 | | |
539 | | - | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
540 | 543 | | |
541 | | - | |
542 | 544 | | |
543 | 545 | | |
544 | 546 | | |
| |||
0 commit comments