Skip to content

Commit 15b24de

Browse files
author
Release Manager
committed
gh-36511: Exclude symlinks from vscode search config via glob pattern As requested in #36380 (comment) and cherry-picked from there. <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes #1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #36511 Reported by: Matthias Köppe Reviewer(s): Tobias Diez
2 parents 0a0f141 + a848f1e commit 15b24de

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

.vscode/settings.json

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,14 @@
88
"src/**/*.so": true
99
},
1010
"search.exclude": {
11-
"build/pkgs/sagemath_categories/src": true,
12-
"build/pkgs/sagemath_objects/src": true,
13-
"build/pkgs/sagelib/src": true,
14-
"pkgs/sage-conf_pypi/sage_root/build": true,
15-
"pkgs/sagemath-categories/sage": true,
16-
"pkgs/sagemath-objects/sage": true,
17-
"pkgs/sagemath-standard/sage": true
11+
// Exclude symbolic links into SAGE_ROOT/pkgs/
12+
"build/pkgs/*/src": true,
13+
// Exclude symbolic links into SAGE_ROOT/src/
14+
"pkgs/sage-conf_conda/sage_root": true,
15+
"pkgs/sage-conf_pypi/sage_root": true,
16+
"pkgs/sage-docbuild/sage_docbuild": true,
17+
"pkgs/sage-setup/sage_setup": true,
18+
"pkgs/sagemath-*/sage": true
1819
},
1920
"python.testing.pytestEnabled": true,
2021
"python.testing.pytestArgs": [

src/doc/en/developer/packaging_sage_library.rst

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -190,9 +190,6 @@ The technique of using symbolic links pointing into ``SAGE_ROOT/src``
190190
has allowed the modularization effort to keep the ``SAGE_ROOT/src``
191191
tree monolithic: Modularization has been happening behind the scenes
192192
and will not change where Sage developers find the source files.
193-
When adding a new distribution package that uses a symbolic link pointing into
194-
``SAGE_ROOT/src``, please update ``search.exclude`` in
195-
``SAGE_ROOT/.vscode/settings.json``.
196193

197194
Some of these files may actually be generated from source files with suffix ``.m4`` by the
198195
``SAGE_ROOT/bootstrap`` script via the ``m4`` macro processor.

0 commit comments

Comments
 (0)