-
-
Notifications
You must be signed in to change notification settings - Fork 433
Feature/portscan detection #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/inspection-framework
Are you sure you want to change the base?
Conversation
Add primitive encryption detection system
aa5237a to
cc0664d
Compare
ppacher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that contribution @Raskaro! 🎉
I just did an technical review (no testing yet) and added some comments and change requests. Please have a look before we can merge them to the inspection branch. I'll try to test ASAP 🔜
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! Some cleanup requested.
Also, please add a prefix to your log messages, so that one can easily discern where the log originiates from. Would suggest using portscan-detection: .
1e901b5 to
846e6cc
Compare
ce67f03 to
85feeb3
Compare
85feeb3 to
0c6a7fc
Compare
|
@ppacher I pushed the final changes. Re-Review when you have time. |
|
Safing seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
7cd8005 to
efec52b
Compare
|
I know this is very old but is there a reason this is hanging about? Seems like it was quite close to being ready...two years ago 😅 |
Implemented a Portscan detection.