Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Aug 11, 2020

Implemented a Portscan detection.

@ghost ghost requested a review from ppacher August 11, 2020 13:06
@ghost ghost force-pushed the feature/portscan_detection branch from aa5237a to cc0664d Compare August 11, 2020 13:22
Copy link
Contributor

@ppacher ppacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that contribution @Raskaro! 🎉

I just did an technical review (no testing yet) and added some comments and change requests. Please have a look before we can merge them to the inspection branch. I'll try to test ASAP 🔜

Copy link
Member

@dhaavi dhaavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Some cleanup requested.

Also, please add a prefix to your log messages, so that one can easily discern where the log originiates from. Would suggest using portscan-detection: .

@ghost ghost force-pushed the feature/portscan_detection branch from 1e901b5 to 846e6cc Compare August 13, 2020 14:28
@ghost ghost force-pushed the feature/portscan_detection branch 3 times, most recently from ce67f03 to 85feeb3 Compare August 14, 2020 11:14
@ghost ghost force-pushed the feature/portscan_detection branch from 85feeb3 to 0c6a7fc Compare August 14, 2020 12:42
@ghost
Copy link
Author

ghost commented Aug 14, 2020

@ppacher I pushed the final changes. Re-Review when you have time.

@CLAassistant
Copy link

CLAassistant commented Mar 30, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ dhaavi
❌ Safing


Safing seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ppacher ppacher force-pushed the feature/inspection-framework branch from 7cd8005 to efec52b Compare September 2, 2021 15:04
@JS-E
Copy link

JS-E commented Jun 23, 2022

I know this is very old but is there a reason this is hanging about? Seems like it was quite close to being ready...two years ago 😅

@dhaavi
Copy link
Member

dhaavi commented Jul 14, 2022

@JS-E, this is waiting for #92 - which is currently blocked and we currently need to focus elsewhere.
But yes, it is almost done, except for some critical integration parts we need to figure out first, as this changes how we handle a couple things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants