Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Blockaid): non_dapp: true #5129

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Fix(Blockaid): non_dapp: true #5129

merged 1 commit into from
Feb 26, 2025

Conversation

katspaugh
Copy link
Member

What it solves

The metadata Blockaid API parameter wasn't passed correctly.

Copy link

github-actions bot commented Feb 26, 2025

Copy link

📦 Next.js Bundle Analysis for @safe-global/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.06 MB (🟡 +70.64 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirty-two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 509 B (🟢 -1 B) 1.06 MB
/address-book 23.21 KB (🟡 +143 B) 1.08 MB
/apps 31.73 KB (🟢 -2 KB) 1.09 MB
/apps/custom 29.79 KB (🟢 -2 KB) 1.09 MB
/apps/open 51.33 KB (🟢 -2.28 KB) 1.11 MB
/balances 29.75 KB (🟡 +47 B) 1.09 MB
/balances/nfts 9.32 KB (🟢 -233 B) 1.07 MB
/bridge 2.55 KB (🟢 -5 B) 1.06 MB
/cookie 8.77 KB (🟡 +1 B) 1.07 MB
/home 57.21 KB (🟢 -2.05 KB) 1.11 MB
/licenses 2.46 KB (🟢 -1 B) 1.06 MB
/new-safe/advanced-create 26.38 KB (🟢 -75 B) 1.08 MB
/new-safe/create 25.52 KB (🟢 -67 B) 1.08 MB
/privacy 14.57 KB (🟡 +2 B) 1.07 MB
/settings/appearance 2.25 KB (🟡 +1 B) 1.06 MB
/settings/cookies 1.87 KB (🟡 +1 B) 1.06 MB
/settings/modules 3 KB (🟢 -1.05 KB) 1.06 MB
/settings/notifications 7.52 KB (🟢 -13.8 KB) 1.07 MB
/settings/safe-apps 16.11 KB (🟢 -2.17 KB) 1.07 MB
/settings/security 2.34 KB (🟡 +2 B) 1.06 MB
/settings/setup 30.97 KB (🟡 +246 B) 1.09 MB
/share/safe-app 7.55 KB (🟢 -8 B) 1.07 MB
/stake 617 B (🟢 -2 B) 1.06 MB
/swap 763 B (🟡 +3 B) 1.06 MB
/terms 12.93 KB (🟡 +1 B) 1.07 MB
/transactions 94.52 KB (🟢 -2.05 KB) 1.15 MB
/transactions/history 94.48 KB (🟢 -2.05 KB) 1.15 MB
/transactions/messages 56.21 KB (🟢 -2.09 KB) 1.11 MB
/transactions/msg 52.47 KB (🟢 -2.09 KB) 1.11 MB
/transactions/queue 45.32 KB (🟢 -2.08 KB) 1.1 MB
/transactions/tx 44.68 KB (🟢 -2.08 KB) 1.1 MB
/welcome/accounts 408 B (🟡 +1 B) 1.06 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report for apps/web

St.
Category Percentage Covered / Total
🟡 Statements
77.54% (+0.01% 🔼)
14084/18163
🔴 Branches 57.05% 3565/6249
🟡 Functions 62.94% 2123/3373
🟡 Lines
78.97% (+0.01% 🔼)
12709/16093
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / index.ts
85.71%
44.44% (-5.56% 🔻)
50% 85.71%

Test suite run success

1834 tests passing in 251 suites.

Report generated by 🧪jest coverage report action from 70f915c

@katspaugh katspaugh merged commit a872a74 into release Feb 26, 2025
6 of 11 checks passed
@katspaugh katspaugh deleted the nondapp branch February 26, 2025 09:37
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant