Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): added margin for continue button in ImportAccount and AddSigners fixes #5069 #5119

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

chiranjeev13
Copy link

What it solves

Resolves #5069

Environment

Iphone 16 (Xcode Simulator)

How this PR fixes it

kept bottom margin to 70px in <SafeButton /> component which adjusts to the keyboard properly in both
apps/mobile/src/features/ImportReadOnly/components/ImportAccountFormView.tsx
apps/mobile/src/features/ImportReadOnly/components/AddSignersFormView.tsx

How to test it

Add an account in the ios app

Screen Recordings

Simulator.Screen.Recording.-.SafeFork.-.2025-02-25.at.12.34.54.mp4

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@chiranjeev13 chiranjeev13 changed the title added margin for continue button in ImportAccount and AddSigners fixes #5069 fix(app:ios): added margin for continue button in ImportAccount and AddSigners fixes #5069 Feb 25, 2025
@chiranjeev13 chiranjeev13 changed the title fix(app:ios): added margin for continue button in ImportAccount and AddSigners fixes #5069 fix(mobile): added margin for continue button in ImportAccount and AddSigners fixes #5069 Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IOS: Some buttons are to low at the bottom and hidden under keyboard
1 participant