feat(web): add keystone wallet back #5062
Conversation
We had to remove keystone from the list of wallets in this PR: https://github.com/safe-global/safe-wallet-monorepo/pull/4686/files as the previous package had a faulty dependency that didn’t resolve with yarn v4. This has been resolved here: blocknative/web3-onboard#2322 And I’m adding keystone back
Branch preview✅ Deploy successful! Storybook: |
📦 Next.js Bundle Analysis for @safe-global/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
1.06 MB (🟡 +75.44 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Thirty-five Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/ |
509 B (🟢 -1 B) |
1.06 MB |
/address-book |
23.21 KB (🟡 +150 B) |
1.09 MB |
/apps |
35.75 KB (🟡 +2.03 KB) |
1.1 MB |
/apps/custom |
33.82 KB (🟡 +2.03 KB) |
1.1 MB |
/apps/open |
55.36 KB (🟡 +1.75 KB) |
1.12 MB |
/balances |
29.71 KB (🟡 +8 B) |
1.09 MB |
/balances/nfts |
9.31 KB (🟢 -235 B) |
1.07 MB |
/bridge |
2.55 KB (🟢 -4 B) |
1.07 MB |
/cookie |
8.77 KB (🟡 +1 B) |
1.07 MB |
/home |
61.33 KB (🟡 +2.07 KB) |
1.12 MB |
/licenses |
2.46 KB (🟢 -1 B) |
1.06 MB |
/new-safe/advanced-create |
26.38 KB (🟢 -77 B) |
1.09 MB |
/new-safe/create |
25.52 KB (🟢 -70 B) |
1.09 MB |
/privacy |
14.57 KB (🟡 +2 B) |
1.08 MB |
/settings/appearance |
2.25 KB (🟡 +1 B) |
1.06 MB |
/settings/cookies |
1.87 KB (🟡 +1 B) |
1.06 MB |
/settings/data |
1.79 KB (🟢 -1 B) |
1.06 MB |
/settings/environment-variables |
3.28 KB (🟡 +1 B) |
1.07 MB |
/settings/modules |
2.88 KB (🟢 -1.18 KB) |
1.07 MB |
/settings/notifications |
7.49 KB (🟢 -13.82 KB) |
1.07 MB |
/settings/safe-apps |
20.15 KB (🟡 +1.87 KB) |
1.08 MB |
/settings/security |
2.34 KB (🟡 +2 B) |
1.06 MB |
/settings/setup |
30.98 KB (🟡 +256 B) |
1.09 MB |
/share/safe-app |
7.55 KB (🟢 -9 B) |
1.07 MB |
/stake |
617 B (🟢 -2 B) |
1.06 MB |
/swap |
763 B (🟡 +3 B) |
1.06 MB |
/terms |
12.93 KB (🟡 +1 B) |
1.08 MB |
/transactions |
99.46 KB (🟡 +2.88 KB) |
1.16 MB |
/transactions/history |
99.42 KB (🟡 +2.88 KB) |
1.16 MB |
/transactions/messages |
60.25 KB (🟡 +1.95 KB) |
1.12 MB |
/transactions/msg |
56.5 KB (🟡 +1.95 KB) |
1.12 MB |
/transactions/queue |
49.36 KB (🟡 +1.96 KB) |
1.11 MB |
/transactions/tx |
48.72 KB (🟡 +1.96 KB) |
1.11 MB |
/welcome |
6.93 KB (🟢 -2 B) |
1.07 MB |
/welcome/accounts |
408 B (🟡 +1 B) |
1.06 MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 77.32% | 14222/18394 |
| 🔴 | Branches | 56.14% | 3570/6359 |
| 🟡 | Functions | 62.28% | 2123/3409 |
| 🟡 | Lines | 78.79% | 12842/16300 |
Test suite run success
1838 tests passing in 251 suites.
Report generated by 🧪jest coverage report action from 29ab6b7
Moved back - the error instead of the QR code
|
What it solves
We had to remove keystone from the list of wallets in this PR: https://github.com/safe-global/safe-wallet-monorepo/pull/4686/files as the previous package had a faulty dependency that didn’t resolve with yarn v4. This has been resolved here:
blocknative/web3-onboard#2322
And I’m adding keystone back
Screenshots
Checklist