Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: safe-global/safe-wallet-monorepo
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: dev@{1day}
Choose a base ref
...
head repository: safe-global/safe-wallet-monorepo
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: dev
Choose a head ref
  • 2 commits
  • 22 files changed
  • 3 contributors

Commits on Feb 27, 2025

  1. fix(permissions): check spending limits for connected wallet (#5030) 

    * feat(permissions): enhance permission checks with common props

The common props include safe and wallet info and are passed when permission functions are called.

* fix(permissions): filter spending limit by connected wallet address

Update spending limit transaction checks to use token address

* fix(permissions): include safe and wallet in dependency array for userPermissions

* refactor(tests): change imports to type imports in config.test.ts

* fix(tests): include wallet owners in role permissions test setup

* fix(tests): include wallet owners in mock safe setup for role permissions tests

* fix(tests): enhance mock spending limits with dynamic values for better test coverage

* fix(permissions): use sameAddress utility for spending limit beneficiary checks
    @tmjssz
    tmjssz authored Feb 27, 2025
    Configuration menu
    Copy the full SHA
    1f55f4c View commit details
    Browse the repository at this point in the history

  2. Add UI tests (#5155) 

    Co-authored-by: mike10ca <michael@safe.global>
    @francovenica @mike10ca
    francovenica and mike10ca authored Feb 27, 2025
    Configuration menu
    Copy the full SHA
    f35a66e View commit details
    Browse the repository at this point in the history
Loading