Bump web3 to v7 and safe-eth-py to v7 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13434664562Details
💛 - Coveralls |
Uxio0
requested changes
Feb 20, 2025
| @@ -68,7 +68,7 @@ def __init__(self): | |||
|
|
|||
| @staticmethod | |||
| async def _store_abis_in_database( | |||
| abi_jsons: list[Sequence[ABIFunction | ABIEvent]], | |||
| abi_jsons: list[ABI], | |||
There was a problem hiding this comment.
Why? ABIFunction is not the same as ABI
There was a problem hiding this comment.
Because of this, the Contract class in web3, is returning ABI (ABI = Sequence[ABIElement]) as type for the abi attribute.
For example, in functions like: get_multi_send_contract(self.dummy_w3).abi.
Mypy is warning of this problem
Co-authored-by: Uxío <Uxio0@users.noreply.github.com>
Co-authored-by: Uxío <Uxio0@users.noreply.github.com>
Uxio0
approved these changes
Feb 20, 2025
This was referenced Feb 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.