-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Rename UserOrganizationsDto to UserOrganizationDto #2374
Conversation
WalkthroughA rename was performed in the organizations DTO file. The class Changes
Suggested reviewers
Poem
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/routes/organizations/entities/get-organization.dto.entity.ts
(2 hunks)
🔇 Additional comments (2)
src/routes/organizations/entities/get-organization.dto.entity.ts (2)
21-21
: LGTM! The rename improves clarity and fixes the Swagger issue.The rename from
UserOrganizationsDto
toUserOrganizationDto
is appropriate as it:
- Resolves the naming conflict that was causing Swagger to fetch incorrect types
- Better reflects that this DTO represents a single user-organization relationship
54-55
: LGTM! The type update is consistent with the rename.The property type update correctly reflects the renamed DTO while maintaining the array relationship.
Summary
This PR changes the name of
userOrganizationsDto
in https://github.com/safe-global/safe-client-gateway/blob/9d6191df34eddcb2f7ec328f9523468ca0778f3e/src/routes/organizations/entities/get-organization.dto.entity.tsSince another exported class shares the same name, Swagger attempted to fetch the type from that class instead of the one defined in this file. To resolve the conflict, we renamed the class.
Changes
UserOrganizationsDto
toUserOrganizationDto
Summary by CodeRabbit