Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate/coerce multisig safeTxGas,baseGas and nonce values to numbers #2331

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Feb 6, 2025

Summary

A recent change to the Transaction Service, changed safeTxGas,baseGas and nonce values of multisig transactions to strings. This therefore broke validation.

This adjusts validation of the above fields, allowing both string/number and coerces the value to a string to not affect types client-side.

Changes

@iamacook iamacook added the bug Something isn't working label Feb 6, 2025
@iamacook iamacook self-assigned this Feb 6, 2025
@iamacook iamacook requested a review from a team as a code owner February 6, 2025 14:49
@falvaradorodriguez
Copy link

LGTM!

@iamacook
Copy link
Member Author

iamacook commented Feb 6, 2025

As per discussion, this will be posthumously reviewed by @PooyaRaki as this is currently causing problems on staging.

@iamacook iamacook merged commit 51f074c into main Feb 6, 2025
18 checks passed
@iamacook iamacook deleted the fix/multisig-numeric-string-values branch February 6, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants