fix: validate/coerce multisig safeTxGas
,baseGas
and nonce
values to numbers
#2331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A recent change to the Transaction Service, changed
safeTxGas
,baseGas
andnonce
values of multisig transactions to strings. This therefore broke validation.This adjusts validation of the above fields, allowing both string/number and coerces the value to a string to not affect types client-side.
Changes
CoercedNumberSchema
safeTxGas
,baseGas
andnonce
of multisig transactions