Add trusted query param. to incoming-transfers endpoint
#1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8092707052Details
💛 - Coveralls |
fmrsabino
suggested changes
Feb 28, 2024
src/routes/transactions/mappers/transfers/transfer.mapper.spec.ts
Outdated
Show resolved
Hide resolved
src/routes/transactions/mappers/transfers/transfer.mapper.spec.ts
Outdated
Show resolved
Hide resolved
...ctions/__tests__/controllers/list-incoming-transfers-by-safe.transactions.controller.spec.ts
Outdated
Show resolved
Hide resolved
hectorgomezv
pushed a commit
that referenced
this pull request
Feb 29, 2024
This adds a `trusted` query param. to the `incoming-transfers` endpoints, mirroring that of the `history` endpoint. If `true`, it filters ERC-20 transfers that are untrusted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This resolves #1206 by adding the
trustedquery param. from thehistoryendpoint to theincoming-transfersone. The associated logic has been moved fromTransactionsHistoryMapper['mapTransfers']into a newTransferMapper['mapTransfers']method that accepts anonlyTrustedargument.Changes
trustedquery param toTransactionsController['getIncomingTransfers']TransactionsHistoryMapper['mapTransfers']toTransferMapper['mapTransfers']TransferMapper['mapTransfer']toTransferMapper['mapTransfers']