Reduce allocations on Itoa conversion (go-gorm#85)

moredure · web-flow · commit 9ec45b1aed33 · 2022-03-18T20:15:37.000+08:00
diff --git a/sqlite.go b/sqlite.go
@@ -101,10 +101,12 @@ func (dialector Dialector) ClauseBuilders() map[string]clause.ClauseBuilder {
 					if limit.Limit <= 0 {
 						limit.Limit = -1
 					}
-					builder.WriteString("LIMIT " + strconv.Itoa(limit.Limit))
+					builder.WriteString("LIMIT ")
+					builder.WriteString(strconv.Itoa(limit.Limit))
 				}
 				if limit.Offset > 0 {
-					builder.WriteString(" OFFSET " + strconv.Itoa(limit.Offset))
+					builder.WriteString(" OFFSET ")
+					builder.WriteString(strconv.Itoa(limit.Offset))
 				}
 			}
 		},

Original file line number	Diff line number	Diff line change
`@@ -101,10 +101,12 @@ func (dialector Dialector) ClauseBuilders() map[string]clause.ClauseBuilder {`
`101`	`101`	`if limit.Limit <= 0 {`
`102`	`102`	`limit.Limit = -1`
`103`	`103`	`}`
`104`		`- builder.WriteString("LIMIT " + strconv.Itoa(limit.Limit))`
	`104`	`+ builder.WriteString("LIMIT ")`
	`105`	`+ builder.WriteString(strconv.Itoa(limit.Limit))`
`105`	`106`	`}`
`106`	`107`	`if limit.Offset > 0 {`
`107`		`- builder.WriteString(" OFFSET " + strconv.Itoa(limit.Offset))`
	`108`	`+ builder.WriteString(" OFFSET ")`
	`109`	`+ builder.WriteString(strconv.Itoa(limit.Offset))`
`108`	`110`	`}`
`109`	`111`	`}`
`110`	`112`	`},`