Avoid creating empty flashes. (#45)

sachinchoolur · Oct 25, 2016 · a07c264 · a07c264
1 parent 84a549d
commit a07c264
Show file tree

Hide file tree

Showing 8 changed files with 24 additions and 8 deletions.
diff --git a/dist/angular-flash.css b/dist/angular-flash.css
@@ -1,4 +1,4 @@
-/*! angular-flash - v2.3.0 - 2016-04-24
+/*! angular-flash - v2.3.0 - 2016-08-23
 * https://github.com/sachinchoolur/angular-flash
 * Copyright (c) 2016 Sachin; Licensed MIT */
 

diff --git a/dist/angular-flash.js b/dist/angular-flash.js
diff --git a/dist/angular-flash.js.map b/dist/angular-flash.js.map
diff --git a/dist/angular-flash.min.css b/dist/angular-flash.min.css
diff --git a/dist/angular-flash.min.js b/dist/angular-flash.min.js
diff --git a/dist/angular-flash.min.js.map b/dist/angular-flash.min.js.map
diff --git a/src/angular-flash.js b/src/angular-flash.js
@@ -142,6 +142,7 @@ app.provider('Flash', function() {
         dataFactory.config = defaultConfig;
 
         dataFactory.create = function(type, text, timeout, config, showClose) {
+            if (!text) return false;
             let $this, flash;
             $this = this;
             flash = {

diff --git a/test/angular-flash_test.js b/test/angular-flash_test.js
@@ -27,6 +27,14 @@ describe('Unit testing Angular Flash', function() {
         expect(contents[0].nodeType).toEqual(Node.ELEMENT_NODE);
     });
 
+    it('avoid to display flash when it does not have content', function() {
+        created = Flash.create('success', '');
+        $rootScope.$digest();
+        var contents = node.contents()[0];
+        expect(contents.querySelectorAll('.alert').length).toEqual(0);
+        expect(created).toEqual(false);
+    });
+
     it('has the class specified', function() {
         var testClassName = 'test-class';
         Flash.create('success', 'Good job', 10000, {class: testClassName});