Fix for issue #432. Read the response from httplib even if there is a 0 ... #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re is a 0 byte to read. So httplib doesn't think that there is a response waiting to be read when the next request come.
Straightforward to fix thanks to the detailed analysis of Edwintorok.
<<
This seems to be due to this in python 2.7.9rc1's httplib:
if self.__state != _CS_REQ_SENT or self.__response:
raise ResponseNotReady()
Apparently python created a response object for the content-length: 0 reply (for GET /0) and s3cmd
didn't read/close that response object, and now it gives an error when you try to read anything else on the same persistent connection.
>>
…rror expect an http response, not a text message)
mdomsch
added a commit
that referenced
this pull request
Mar 16, 2015
Fix for issue #432. Read the response from httplib even if there is a 0 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...byte to read. So httplib doesn't think that there is a response waiting to be read when the next request come.
Straightforward to fix thanks to the detailed analysis of Edwintorok.
<<
This seems to be due to this in python 2.7.9rc1's httplib:
Apparently python created a response object for the content-length: 0 reply (for GET /0) and s3cmd
didn't read/close that response object, and now it gives an error when you try to read anything else on the same persistent connection.
#432