Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw/sfs: make multipart complete async, in the background #833

Open
jecluis opened this issue Nov 23, 2023 · 0 comments
Open

rgw/sfs: make multipart complete async, in the background #833

jecluis opened this issue Nov 23, 2023 · 0 comments
Labels
area/rgw-sfs RGW & SFS related kind/enhancement Change that positively impacts existing code severity/major Major loss of function, as specified in the requirements for this release, or existing in the curren triage/next-candidate This could be moved to the next milestone

Comments

@jecluis
Copy link
Contributor

jecluis commented Nov 23, 2023

Currently, we are building the final object synchronously, during the complete request. This works fine because we rely on copy_file_range() to perform the data copy -- thus avoiding reading and writing the data twice, at least on filesystems that support reflinks.

However, we have several places in this function where we can transiently fail, with no prejudice to the validity of the operation itself, and we should be able to retry it at a later stage -- the client will likely not retry the operation, as it expects this operation to be async.

We should ensure that our operation happens in the background, as expected, so that the client does not hang while we build the final objects.

@jecluis jecluis added kind/enhancement Change that positively impacts existing code priority/1 Should be fixed for next release area/rgw-sfs RGW & SFS related severity/major Major loss of function, as specified in the requirements for this release, or existing in the curren labels Nov 23, 2023
@jecluis jecluis added this to the v0.25.0 milestone Nov 23, 2023
@github-actions github-actions bot added the triage/waiting Waiting for triage label Nov 23, 2023
@jecluis jecluis removed the triage/waiting Waiting for triage label Nov 23, 2023
@jecluis jecluis changed the title rgw/sfs: make mulipart complete async, in the background rgw/sfs: make multipart complete async, in the background Mar 21, 2024
@jecluis jecluis added triage/next-candidate This could be moved to the next milestone and removed priority/1 Should be fixed for next release labels Mar 21, 2024
@jecluis jecluis removed this from the v0.25.0 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rgw-sfs RGW & SFS related kind/enhancement Change that positively impacts existing code severity/major Major loss of function, as specified in the requirements for this release, or existing in the curren triage/next-candidate This could be moved to the next milestone
Projects
Status: Backlog
Development

No branches or pull requests

1 participant