Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement omap keys related functions. #763

Open
0xavi0 opened this issue Oct 18, 2023 · 1 comment
Open

Implement omap keys related functions. #763

0xavi0 opened this issue Oct 18, 2023 · 1 comment
Labels
area/rgw-sfs RGW & SFS related kind/bug Something isn't working triage/next-candidate This could be moved to the next milestone

Comments

@0xavi0
Copy link
Contributor

0xavi0 commented Oct 18, 2023

This issue raised after rebasing on top of ceph's 18.2.0.

The test_get_object_torrent is using the omap_get_vals_by_keys call that is not implemented yet in sfs

2023-10-18T14:52:46.880+0200 7f608ac5f6c0  2 req 0 0.003333386s s3:get_obj executing
2023-10-18T14:52:46.880+0200 7f608ac5f6c0 10 req 0 0.003333386s s3:get_obj > object_read::prepare bucket:sfstest-godmouwe4ljmjg4khzwzq-1 obj:Avatar.mpg size:7340032 versionid: conditionals:(ifmatch:0x0 ifnomatch:0x0 ifmod:0x0 ifunmod:0x0)
2023-10-18T14:52:46.880+0200 7f608ac5f6c0  5 req 0 0.003333386s NOTICE: announce_list is empty
2023-10-18T14:52:46.880+0200 7f608ac5f6c0 20 req 0 0.003333386s NOTICE: head obj oid= sfstest-godmouwe4ljmjg4khzwzq-1.1697633566802812419_Avatar.mpg
2023-10-18T14:52:46.880+0200 7f608ac5f6c0 10 req 0 0.003333386s omap_get_vals_by_keys: TODO
2023-10-18T14:52:46.880+0200 7f608ac5f6c0  0 req 0 0.003333386s ERROR: omap_get_vals_by_keys failed: -95
2023-10-18T14:52:46.880+0200 7f608ac5f6c0  0 req 0 0.003333386s s3:get_obj ERROR: failed to get_torrent_file ret= -95

The omap_get_vals_by_keys prints the TODO and returns -ENOTSUP

int SFSObject::omap_get_vals_by_keys(
    const DoutPrefixProvider* dpp, const std::string& /*oid*/,
    const std::set<std::string>& /*keys*/, Attrs* /*vals*/
) {
  ldpp_dout(dpp, 10) << __func__ << ": TODO" << dendl;
  return -ENOTSUP;
}
@0xavi0 0xavi0 added the kind/bug Something isn't working label Oct 18, 2023
@github-actions github-actions bot added the triage/waiting Waiting for triage label Oct 18, 2023
@jecluis
Copy link
Contributor

jecluis commented Oct 19, 2023

what kind of S3 operations rely on omap keys?

@jecluis jecluis added triage/next-candidate This could be moved to the next milestone area/rgw-sfs RGW & SFS related and removed triage/waiting Waiting for triage labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rgw-sfs RGW & SFS related kind/bug Something isn't working triage/next-candidate This could be moved to the next milestone
Projects
Status: Backlog
Development

No branches or pull requests

2 participants