Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unversioned -> Versioned Bucket Transition - Null Versions #687

Open
irq0 opened this issue Aug 30, 2023 · 1 comment
Open

Unversioned -> Versioned Bucket Transition - Null Versions #687

irq0 opened this issue Aug 30, 2023 · 1 comment
Labels
kind/bug Something isn't working required/discussion A discussion within the team is needed triage/next-candidate This could be moved to the next milestone

Comments

@irq0
Copy link
Contributor

irq0 commented Aug 30, 2023

S3 demands that all objects created in an unversioned bucket will have the "null" version id / instance after a bucket becomes versioned.

From https://docs.aws.amazon.com/AmazonS3/latest/userguide/Versioning.html

Objects that are stored in your bucket before you set the versioning state have a version ID of null

Since we treat unversioned as a special case of versioned buckets, we have unique version ids even for unversioned.
In practice this means, that after switching on versioning a user can't address existing objects under the version id "null".

A simple way to be more like S3 would be to set all version ids to "null" on the unversioned -> versioned transition.

S3 tests:

test_versioning_obj_plain_null_version_overwrite
test_versioning_obj_plain_null_version_removal
@irq0 irq0 added kind/bug Something isn't working required/discussion A discussion within the team is needed labels Aug 30, 2023
@github-actions github-actions bot added the triage/waiting Waiting for triage label Aug 30, 2023
@jhmarina jhmarina added priority/2 To be prioritized according to impact and removed triage/waiting Waiting for triage required/discussion A discussion within the team is needed labels Sep 7, 2023
@jecluis
Copy link
Contributor

jecluis commented Oct 19, 2023

I think this needs to be addressed after v0.23.0. I suspect this will require a non-trivial effort.

I believe we will have to document missing this transition in the support matrix, along with suspended versioning.

@vmoutoussamy vmoutoussamy modified the milestones: v0.24.0, v0.26.0 Nov 27, 2023
@jecluis jecluis added triage/next-candidate This could be moved to the next milestone required/discussion A discussion within the team is needed and removed priority/2 To be prioritized according to impact labels Mar 21, 2024
@jecluis jecluis removed this from the v0.26.0 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working required/discussion A discussion within the team is needed triage/next-candidate This could be moved to the next milestone
Projects
Status: Backlog
Development

No branches or pull requests

4 participants