Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Server HTTP Response header should include s3gw version #659

Open
tserong opened this issue Aug 7, 2023 · 2 comments
Open

[FR] Server HTTP Response header should include s3gw version #659

tserong opened this issue Aug 7, 2023 · 2 comments
Labels
area/rgw-sfs RGW & SFS related kind/enhancement Change that positively impacts existing code triage/next-candidate This could be moved to the next milestone

Comments

@tserong
Copy link
Contributor

tserong commented Aug 7, 2023

The HTTP response "Server" header currently says "Ceph Object Gateway (reef)", e.g.:

> curl -D - http://127.0.0.1:7480/ -o /dev/null -s
HTTP/1.1 200 OK
Transfer-Encoding: chunked
Content-Type: application/xml
Date: Mon, 07 Aug 2023 06:51:06 GMT
Server: Ceph Object Gateway (reef)
Connection: Keep-Alive

It would be helpful if this included the s3gw version instead, so that you know exactly what you're talking to, for example:

Server: Ceph Object Gateway (s3gw-v0.19.0)

@tserong tserong added the area/rgw-sfs RGW & SFS related label Aug 7, 2023
@github-actions github-actions bot added the triage/waiting Waiting for triage label Aug 7, 2023
@tserong
Copy link
Contributor Author

tserong commented Aug 7, 2023

We should probably look at allowing the Server string to be overridden/modified/appended based on environment variables, because this would potentially allow us to include information about the deployment environment and storage backend.

@jhmarina
Copy link
Contributor

We don't want to leak the version number, due to probable vulnerabilities, but rather reply something like S3 Gateway instead of Ceph

@jhmarina jhmarina added LH 1.6 and removed triage/waiting Waiting for triage labels Sep 19, 2023
@jecluis jecluis added kind/enhancement Change that positively impacts existing code triage/next-candidate This could be moved to the next milestone and removed LH 1.6 labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rgw-sfs RGW & SFS related kind/enhancement Change that positively impacts existing code triage/next-candidate This could be moved to the next milestone
Projects
Status: Backlog
Development

No branches or pull requests

3 participants