Deleting non-empty buckets should error

[irq0]

Describe the bug

Don't delete non-empty buckets.

S3 Test failing: test_bucket_delete_nonempty

It expects 409 / BucketNotEmpty. We return 204 success.

Docs: https://docs.aws.amazon.com/AmazonS3/latest/userguide/delete-bucket.html

Additional context

rgw log

2023-05-15T16:13:21.786+0000 7f75f16cf700  2 req 0 0.000000000s s3:delete_bucket normalizing buckets and tenants
2023-05-15T16:13:21.786+0000 7f75f16cf700 10 req 0 0.000000000s s->object=<NULL> s->bucket=sfstest-tebvqf8c562mmw29l4pfh-1
2023-05-15T16:13:21.786+0000 7f75f16cf700  2 req 0 0.000000000s s3:delete_bucket init permissions
2023-05-15T16:13:21.786+0000 7f75f16cf700 10 req 0 0.000000000s s3:delete_bucket get_bucket: bucket: sfstest-tebvqf8c562mmw29l4pfh-1
2023-05-15T16:13:21.786+0000 7f75f16cf700  2 req 0 0.000000000s s3:delete_bucket recalculating target
2023-05-15T16:13:21.786+0000 7f75f16cf700  2 req 0 0.000000000s s3:delete_bucket reading permissions
2023-05-15T16:13:21.786+0000 7f75f16cf700  2 req 0 0.000000000s s3:delete_bucket init op
2023-05-15T16:13:21.786+0000 7f75f16cf700 10 get_quota: TODO
2023-05-15T16:13:21.786+0000 7f75f16cf700  2 req 0 0.000000000s s3:delete_bucket verifying op mask
2023-05-15T16:13:21.786+0000 7f75f16cf700  2 req 0 0.000000000s s3:delete_bucket verifying op permissions
2023-05-15T16:13:21.786+0000 7f75f16cf700  5 req 0 0.000000000s s3:delete_bucket Searching permissions for identity=rgw::auth::SysReqApplier -> rgw::auth::LocalApplier(acct_user=0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef, acct_name=youruseridhere, subuser=, perm_mask=15, is_admin=0) mask=50
2023-05-15T16:13:21.786+0000 7f75f16cf700  5 req 0 0.000000000s s3:delete_bucket Searching permissions for uid=0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef
2023-05-15T16:13:21.786+0000 7f75f16cf700  5 req 0 0.000000000s s3:delete_bucket Found permission: 15
2023-05-15T16:13:21.786+0000 7f75f16cf700  5 req 0 0.000000000s s3:delete_bucket Searching permissions for group=1 mask=50
2023-05-15T16:13:21.786+0000 7f75f16cf700  5 req 0 0.000000000s s3:delete_bucket Permissions for group not found
2023-05-15T16:13:21.786+0000 7f75f16cf700  5 req 0 0.000000000s s3:delete_bucket Searching permissions for group=2 mask=50
2023-05-15T16:13:21.786+0000 7f75f16cf700  5 req 0 0.000000000s s3:delete_bucket Permissions for group not found
2023-05-15T16:13:21.786+0000 7f75f16cf700  5 req 0 0.000000000s s3:delete_bucket -- Getting permissions done for identity=rgw::auth::SysReqApplier -> rgw::auth::LocalApplier(acct_user=0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef, acct_name=youruseridhere, subuser=, perm_mask=15, is_admin=0), owner=0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef, perm=2
2023-05-15T16:13:21.786+0000 7f75f16cf700 10 req 0 0.000000000s s3:delete_bucket  identity=rgw::auth::SysReqApplier -> rgw::auth::LocalApplier(acct_user=0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef, acct_name=youruseridhere, subuser=, perm_mask=15, is_admin=0) requested perm (type)=2, policy perm=2, user_perm_mask=2, acl perm=2
2023-05-15T16:13:21.786+0000 7f75f16cf700  2 req 0 0.000000000s s3:delete_bucket verifying op params
2023-05-15T16:13:21.786+0000 7f75f16cf700  2 req 0 0.000000000s s3:delete_bucket pre-executing
2023-05-15T16:13:21.786+0000 7f75f16cf700  2 req 0 0.000000000s s3:delete_bucket check rate limiting
2023-05-15T16:13:21.786+0000 7f75f16cf700 10 get_ratelimit: TODO
2023-05-15T16:13:21.786+0000 7f75f16cf700  2 req 0 0.000000000s s3:delete_bucket executing
2023-05-15T16:13:21.786+0000 7f75f16cf700  2 req 0 0.000000000s s3:delete_bucket completing
2023-05-15T16:13:21.786+0000 7f75f16cf700  2 req 0 0.000000000s s3:delete_bucket op status=0
2023-05-15T16:13:21.786+0000 7f75f16cf700  2 req 0 0.000000000s s3:delete_bucket http status=204
2023-05-15T16:13:21.786+0000 7f75f16cf700  1 ====== req done req=0x7f754bd02740 op status=0 http_status=204 latency=0.000000000s ======
2023-05-15T16:13:21.786+0000 7f75f16cf700  1 beast: 0x7f754bd02740: 127.0.0.1 - 0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef [15/May/2023:16:13:21.786 +0000] "DELETE /sfstest-tebvqf8c562mmw29l4pfh-1 HTTP/1.1" 204 0 - "Boto3/1.24.96 Python/3.10.10 Linux/6.2.12-1-default Botocore/1.27.96" - latency=0.000000000s