Merge pull request aws-actions#539 from lmller/patch-1

docs: make description for "service" parameter less ambiguous.

Author: amazreech

action.yml

@@ -11,7 +11,7 @@ inputs:
     description: 'The number of instantiations of the task to place and keep running in your service.'
     required: false
   service:
-    description: 'The name of the ECS service to deploy to. The action will only register the task definition if no service is given.'
+    description: 'The name of the ECS service to deploy to. If no service is given, the action will not deploy the task, but only register the task definition.'
     required: false
   cluster:
     description: "The name of the ECS service's cluster.  Will default to the 'default' cluster"
@@ -34,6 +34,9 @@ inputs:
   codedeploy-deployment-description:
     description: "A description of the deployment, if the ECS service uses the CODE_DEPLOY deployment controller."
     required: false
+ codedeploy-deployment-config:
+    description: "The name of the AWS CodeDeploy deployment configuration, if the ECS service uses the CODE_DEPLOY deployment controller. If not specified, the value configured in the deployment group or `CodeDeployDefault.OneAtATime` is used as the default."
+    required: false
   force-new-deployment:
     description: 'Whether to force a new deployment of the service. Valid value is "true". Will default to not force a new deployment.'
     required: false

index.js

@@ -183,6 +183,8 @@ async function createCodeDeployDeployment(codedeploy, clusterName, service, task
 
   let codeDeployDescription = core.getInput('codedeploy-deployment-description', { required: false });
 
+  let codeDeployConfig = core.getInput('codedeploy-deployment-config', { required: false });
+
   let deploymentGroupDetails = await codedeploy.getDeploymentGroup({
     applicationName: codeDeployApp,
     deploymentGroupName: codeDeployGroup
@@ -225,6 +227,9 @@ async function createCodeDeployDeployment(codedeploy, clusterName, service, task
   if (codeDeployDescription) {
     deploymentParams.description = codeDeployDescription
   }
+  if (codeDeployConfig) {
+    deploymentParams.deploymentConfigName = codeDeployConfig
+  }
   const createDeployResponse = await codedeploy.createDeployment(deploymentParams);
   core.setOutput('codedeploy-deployment-id', createDeployResponse.deploymentId);
 

index.test.js

@@ -143,7 +143,7 @@ describe('Deploy to ECS', () => {
                 failures: [],
                 services: [{
                     status: 'ACTIVE',
-                    deploymentController: { 
+                    deploymentController: {
                         type: 'ECS'
                     }
                 }]
@@ -763,7 +763,7 @@ describe('Deploy to ECS', () => {
         expect(waitUntilServicesStable).toHaveBeenCalledTimes(0);
     });
 
-    test('registers the task definition contents and creates a CodeDeploy deployment with custom application, deployment group and description', async () => {
+    test('registers the task definition contents and creates a CodeDeploy deployment with custom application, deployment group, description and config', async () => {
         core.getInput = jest
             .fn(input => {
                 return {
@@ -773,7 +773,8 @@ describe('Deploy to ECS', () => {
                     'wait-for-service-stability': 'TRUE',
                     'codedeploy-application': 'Custom-Application',
                     'codedeploy-deployment-group': 'Custom-Deployment-Group',
-                    'codedeploy-deployment-description': 'Custom-Deployment'
+                    'codedeploy-deployment-description': 'Custom-Deployment',
+                    'codedeploy-deployment-config': 'CodeDeployDefault.AllAtOnce'
                 }[input];
             });
 
@@ -802,6 +803,7 @@ describe('Deploy to ECS', () => {
         expect(mockCodeDeployCreateDeployment).toHaveBeenNthCalledWith(1, {
             applicationName: 'Custom-Application',
             deploymentGroupName: 'Custom-Deployment-Group',
+            deploymentConfigName: 'CodeDeployDefault.AllAtOnce',
             description: 'Custom-Deployment',
             revision: {
                 revisionType: 'AppSpecContent',