Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYI, small changes to Julia wildboottest() interface #103

Closed
droodman opened this issue Apr 1, 2023 · 2 comments
Closed

FYI, small changes to Julia wildboottest() interface #103

droodman opened this issue Apr 1, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@droodman
Copy link
Collaborator

droodman commented Apr 1, 2023

I just posted version 0.9.7 of WildBootTests.jl. It includes a couple of changes to the optional arguments, which shouldn't affect fwildclusterboot very much:

  1. The NFE argument is no longer accepted. This was a way to tell the program how many fixed-effect groups there are, and served only to save a little time.
  2. It now accepts a Boolean argument overwrite, which communicates that it's OK to overwrite the supplied data matrices. This saves time and memory in some cases. Probably you can use this because I expect that in the transfer of data from R to Julia, the matrices are being copied, and it's fine to dirty the temporary Julia copies. This option helps less often than one might hope. If the data are clustered and issorted=false, then wildboottest() needs to sort the data by cluster, and it does so by storing the sorted data in new matrices anyway. (Sorting in place is not necessarily faster.) Then it never touches the user's data matrices after that, and the overwrite option doesn't matter. Another way to invoke the overwrite option is to call wildboottest! instead of wildboottest.
  3. FWIW, I added waldtest() and scoretest() functions, which correspond to commands of the same name in the Stata package.

I've made a lot of speed improvements to the WRE in the last few months, so hopefully you'll see that in any benchmarks you run.

@s3alfisc
Copy link
Owner

s3alfisc commented Apr 2, 2023

Hi David - thanks for the update! I will have some free time over the Easter break and will take a closer look / try to accommodate all these changes then. I will let you know about any updates!

@s3alfisc s3alfisc added the enhancement New feature or request label Apr 2, 2023
@s3alfisc s3alfisc pinned this issue Apr 2, 2023
@s3alfisc
Copy link
Owner

s3alfisc commented Apr 10, 2023

It looks like CIs have changed slightly, I will have to update my unit tests, which fail under the newest version of WildBootTests.jl (so I think these are false positives). link to CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants