Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved access to discover message attribute inside 'if message is not None' statement #731

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Moved access to discover message attribute inside 'if message is not None' statement #731

merged 1 commit into from
Jun 16, 2020

Conversation

jthure
Copy link
Contributor

@jthure jthure commented Jun 16, 2020

If m is None, which happens if discovery fails, then header = m.header.value is failing. It should be inside the check that m is not None

@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.289% when pulling 7ab535d on jthure:send_handshake_fix into 8a88057 on rytilahti:master.

@rytilahti
Copy link
Owner

Indeed, well spotted, thanks for the PR! 👍

@rytilahti rytilahti merged commit b0a28f0 into rytilahti:master Jun 16, 2020
This was referenced Jul 2, 2020
Closed
Closed
@rytilahti rytilahti mentioned this pull request Jul 20, 2020
Closed
@rytilahti rytilahti mentioned this pull request Jul 27, 2020
Closed
xvlady pushed a commit to xvlady/python-miio that referenced this pull request May 9, 2021
@jthure @xvlady
Moved access to message attribute inside if message is not Not statem…
cb00daa 
…ent (rytilahti#731)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jthure @coveralls @rytilahti