Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for fanspeeds of Roborock E2 (E20/E25) #718

Merged
merged 1 commit into from
Jun 6, 2020
Merged

Add support for fanspeeds of Roborock E2 (E20/E25) #718

merged 1 commit into from
Jun 6, 2020

Conversation

tribut
Copy link
Contributor

@tribut tribut commented Jun 5, 2020

This adds the fan speed names as reported by the official app for the Roborock E2.

Cf. #468 (comment)

@coveralls
Copy link

coveralls commented Jun 5, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 73.339% when pulling 78cda41 on tribut:e2-fanspeeds into dd0255c on rytilahti:master.

rytilahti
rytilahti reviewed Jun 5, 2020
View reviewed changes
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise, but I think it would be better to use the same naming scheme as for the rest of the speeds. This will allow easier mapping on downstream, if/when they simply use the enum name in user visible element.

@tribut
Copy link
Contributor Author

tribut commented Jun 5, 2020

Alright, updated PR accordingly.

@rytilahti
Copy link
Owner

Looks good! Please run tox -e lint to make the tests pass. Also, if you want to hold the original namings, you could add a comment for the enum.

@tribut
Copy link
Contributor Author

tribut commented Jun 6, 2020

Updated and rebased.

@rytilahti
Copy link
Owner

Thanks 🎉

@rytilahti rytilahti merged commit f92e80f into rytilahti:master Jun 6, 2020
@tribut tribut mentioned this pull request Jun 10, 2020
Merged
xvlady pushed a commit to xvlady/python-miio that referenced this pull request May 9, 2021
@tribut @xvlady
Add support for fanspeeds of Roborock E2 (E20/E25) (rytilahti#718)
3b194b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rytilahti rytilahti rytilahti left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tribut @coveralls @rytilahti