add AqaraWallOutlet support #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rytilahti can you also merge this? |
|
Looks good to me, but if it's fine for you, we could wait until we also know the control commands so that they can be added in a single PR? |
|
yea that is fine, was just pushing fast to see if I could get it in 0.5.1, but since that is already out, lets indeed wait for the controll commands. |
|
Yeah, when the prepare release PR hits the master, the release is already "done" at that point. I could have waited out for a bit, but as I had some free time I thought it'd be a good idea to make a quick release to unblock some downstream PRs. |
|
@rytilahti this has been comfirmed to work by @miway80, So this can now be merged. |
xvlady
pushed a commit
to xvlady/python-miio
that referenced
this pull request
May 9, 2021
* add AqaraWallOutlet support * black formatting * add AqaraWallOutlet control capability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue #650