Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viomi: Use bin_type instead of box_type for cli tool #695

Merged
merged 1 commit into from
May 12, 2020

Conversation

rytilahti
Copy link
Owner

Fixes #694

@rytilahti rytilahti changed the title Use bin_type instead of box_type for cli tool Viomi: Use bin_type instead of box_type for cli tool May 8, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.206% when pulling e1ce653 on fix/viomi_bintype into 7a27314 on master.

@Zaschii
Copy link

Zaschii commented May 24, 2020

after boy_type it seems that mop_type is also wrong or missing...

Traceback (most recent call last):
File "/usr/local/bin/miiocli", line 8, in
sys.exit(create_cli())
File "/usr/local/lib/python3.7/dist-packages/miio/cli.py", line 44, in create_cli
return cli(auto_envvar_prefix="MIIO")
File "/usr/local/lib/python3.7/dist-packages/miio/click_common.py", line 59, in call
return self.main(*args, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 782, in main
rv = self.invoke(ctx)
File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 1259, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 1259, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 1066, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 610, in invoke
return callback(*args, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/miio/click_common.py", line 285, in wrap
result_msg = result_msg_fmt.format(**kwargs)
AttributeError: 'ViomiVacuumStatus' object has no attribute 'mop_type'

@rytilahti rytilahti deleted the fix/viomi_bintype branch May 24, 2020 13:40
xvlady pushed a commit to xvlady/python-miio that referenced this pull request May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.5.0 / 0.5.0.1 breaks viomivacuum status
3 participants