Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pwzn relay #537

Merged
merged 6 commits into from
Sep 11, 2019
Merged

Add pwzn relay #537

merged 6 commits into from
Sep 11, 2019

Conversation

SchumyHao
Copy link
Contributor

Signed-off-by: SchumyHao schumyhaojl@126.com

houndci-bot
houndci-bot reviewed Aug 4, 2019
View reviewed changes
miio/pwzn_relay.py Show resolved Hide resolved
miio/pwzn_relay.py Outdated Show resolved Hide resolved
miio/pwzn_relay.py Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.2%) to 70.753% when pulling 9b8173a on SchumyHao:master into dd01456 on rytilahti:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.2%) to 70.753% when pulling 9b8173a on SchumyHao:master into dd01456 on rytilahti:master.

rytilahti
rytilahti requested changes Aug 8, 2019
View reviewed changes
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for the PR! Do you have more information about device besides the model? I left some comments behind which will make the code much cleaner.

miio/pwzn_relay.py Outdated Show resolved Hide resolved
miio/pwzn_relay.py Outdated Show resolved Hide resolved
@SchumyHao
Copy link
Contributor Author

Hi @rytilahti

There are two device models pwzn.relay.apple pwzn.relay.banana
Device is like this
image

@SchumyHao
Copy link
Contributor Author

I update code as @rytilahti requied

@rytilahti
Copy link
Owner

Looks good, thanks! Can you update README's supported devices section? Also, are these relays discoverable? If so, please adjust the discovery.py accordingly, and this can then be merged!

@SchumyHao
Copy link
Contributor Author

Hi @rytilahti

Sorry for late response. I'm busy with my work those days.

This device can not discovered token is not accessable.
So I only update README.

@SchumyHao
Add pwzn relay
ae34863 
Signed-off-by: SchumyHao <schumyhaojl@126.com>
@SchumyHao
Fix hound issue
425375d 
Signed-off-by: SchumyHao <schumyhaojl@126.com>
@SchumyHao
return relay_state directly
de21730 
Signed-off-by: SchumyHao <schumyhaojl@126.com>
@SchumyHao
Add pwzn.relay.banana support
614e7eb 
Signed-off-by: SchumyHao <schumyhaojl@126.com>
@SchumyHao
Get relay names in one function
713c0aa 
Signed-off-by: SchumyHao <schumyhaojl@126.com>
@SchumyHao
Add xiaomi 16 relay module in readme
61103cd 
Signed-off-by: SchumyHao <schumyhaojl@126.com>
@SchumyHao
Copy link
Contributor Author

Any update about this PR?
I checked the CI error logs, it seems not caused by my patches

@rytilahti
Copy link
Owner

Indeed, the errors are odd, do you have an idea @syssi? This can be merged now though, thanks @SchumyHao! 🎉

@rytilahti rytilahti merged commit 7df6821 into rytilahti:master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@syssi syssi syssi left review comments

@rytilahti rytilahti rytilahti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SchumyHao @coveralls @rytilahti @syssi @houndci-bot