-
-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial support for aqara camera (lumi.camera.aq1) #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 1, 2018
houndci-bot
reviewed
Sep 7, 2018
houndci-bot
reviewed
Sep 7, 2018
Any updates on this? |
I think this could be merged after I fix those linting issues, this comment summarizes the current state: #373 (comment) -- edit: merging this now, help for extending the support as well as separate bug reports & PRs are very welcome! |
rytilahti
changed the title
WIP: Add initial support for aqara camera
Add initial support for aqara camera (lumi.camera.aq1)
Dec 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds preliminary support for xiaomi aqara camera (lumi.camera.aq1) and thus fixing #373 and #347. Note that this allows only controlling the camera, in order to access the video stream you have to resort to other solutions (see https://github.com/miguelangel-nubla/videoP2Proxy)
There are plenty of todos and all this code is untested, so please test and report back!