Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for aqara camera (lumi.camera.aq1) #375

Merged
merged 6 commits into from
Dec 8, 2018
Merged

Conversation

rytilahti
Copy link
Owner

@rytilahti rytilahti commented Sep 1, 2018

This adds preliminary support for xiaomi aqara camera (lumi.camera.aq1) and thus fixing #373 and #347. Note that this allows only controlling the camera, in order to access the video stream you have to resort to other solutions (see https://github.com/miguelangel-nubla/videoP2Proxy)

There are plenty of todos and all this code is untested, so please test and report back!

miio/aqaracamera.py Outdated Show resolved Hide resolved
miio/aqaracamera.py Outdated Show resolved Hide resolved
miio/aqaracamera.py Show resolved Hide resolved
miio/aqaracamera.py Outdated Show resolved Hide resolved
miio/aqaracamera.py Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 70.47% when pulling 48e9fed on aqaracam into 11ea2a0 on master.

@coveralls
Copy link

coveralls commented Sep 1, 2018

Coverage Status

Coverage decreased (-0.6%) to 72.632% when pulling 8b838a8 on aqaracam into eb459cd on master.

miio/aqaracamera.py Show resolved Hide resolved
miio/aqaracamera.py Show resolved Hide resolved
miio/aqaracamera.py Show resolved Hide resolved
miio/aqaracamera.py Show resolved Hide resolved
@IamMikl
Copy link

IamMikl commented Dec 7, 2018

Any updates on this?

@rytilahti
Copy link
Owner Author

rytilahti commented Dec 8, 2018

I think this could be merged after I fix those linting issues, this comment summarizes the current state: #373 (comment) -- edit: merging this now, help for extending the support as well as separate bug reports & PRs are very welcome!

@rytilahti rytilahti changed the title WIP: Add initial support for aqara camera Add initial support for aqara camera (lumi.camera.aq1) Dec 8, 2018
@rytilahti rytilahti merged commit 9ba523c into master Dec 8, 2018
@rytilahti rytilahti deleted the aqaracam branch December 8, 2018 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants