-
-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve gateway get_devices_from_dict #1456
Conversation
@rytilahti could you review and merge? |
Codecov Report
@@ Coverage Diff @@
## master #1456 +/- ##
==========================================
- Coverage 83.35% 83.32% -0.04%
==========================================
Files 139 139
Lines 13670 13675 +5
Branches 3248 3249 +1
==========================================
Hits 11395 11395
- Misses 2057 2062 +5
Partials 218 218
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
@rytilahti thanks for the review, I have processed your feedback. |
I think the test failure is unrelated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please add a note to description on why/how this improves it, then this is ready to go.
@rytilahti I updated the description of the PR, ready to go. |
Improve the get_devices_from_dict function of the gateway:
Now the device_id from direct communication is checked against the device_id received from the cloud.
Besides the already presend mac matching.
The _did is removed from the gateway since it is the same as the device_id which was already presend.