Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved fanspeed mapping for Roborock S7 MaxV #1454

Merged
merged 5 commits into from
Jul 11, 2022

Conversation

arthur-morgan-1
Copy link
Contributor

@arthur-morgan-1 arthur-morgan-1 commented Jul 11, 2022

Added the highest suction power (fanspeed) to Roborock S7 MaxV ultra
This speed is called "Max+" within the app, can be triggered by command "108".

Adding fanspeed (vacuum power) support for Roborock S7 MaxV "MAX+" power (Highest)
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022

Codecov Report

Merging #1454 (1b86bc2) into master (c3efcb4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           master    #1454     +/-   ##
=========================================
  Coverage   84.19%   84.20%             
=========================================
  Files         135      135             
  Lines       13449    13457      +8     
  Branches     1499     3218   +1719     
=========================================
+ Hits        11324    11332      +8     
  Misses       1907     1907             
  Partials      218      218             
Impacted Files Coverage Δ
miio/integrations/vacuum/roborock/vacuum.py 65.20% <100.00%> (+0.53%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arthur-morgan-1! 👍

@rytilahti rytilahti changed the title Adding fanspeed (vacuum power) support for Roborock S7 MaxV Improved fanspeed mapping for Roborock S7 MaxV Jul 11, 2022
@rytilahti rytilahti merged commit 0998568 into rytilahti:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants