Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable fail-fast on CI tests #1450

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Conversation

rytilahti
Copy link
Owner

@rytilahti rytilahti commented Jul 8, 2022

Mac builds (and potentially windows, too) on 3.11-dev are failing with the error shown below, so this disables fail-fast to avoid canceling the rest of the tests. This is necessary as the master is a protected branch that requires that specific tests are passing prior merging.

Command ['/Users/runner/Library/Caches/pypoetry/virtualenvs/python-miio-T8lMymkM-py3.11/bin/pip', 'install', '--no-deps', '/Users/runner/Library/Caches/pypoetry/artifacts/be/39/d8/f0989f51991610d463a30d1624ab1eb3f110ba5d028fc976d08166e36d/imagesize-1.3.0-py2.py3-none-any.whl'] errored with the following return code 1, and output: 
Processing /Users/runner/Library/Caches/pypoetry/artifacts/be/39/d8/f0989f51991610d463a30d1624ab1eb3f110ba5d028fc976d08166e36d/imagesize-1.3.0-py2.py3-none-any.whl
Installing collected packages: imagesize
Successfully installed imagesize
Traceback (most recent call last):
  File "/Users/runner/Library/Caches/pypoetry/virtualenvs/python-miio-T8lMymkM-py3.11/bin/pip", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/runner/Library/Caches/pypoetry/virtualenvs/python-miio-T8lMymkM-py3.11/lib/python3.11/site-packages/pip/_internal/cli/main.py", line 70, in main
    return command.main(cmd_args)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/runner/Library/Caches/pypoetry/virtualenvs/python-miio-T8lMymkM-py3.11/lib/python3.11/site-packages/pip/_internal/cli/base_command.py", line 101, in main
    return self._main(args)
           ^^^^^^^^^^^^^^^^
  File "/Users/runner/Library/Caches/pypoetry/virtualenvs/python-miio-T8lMymkM-py3.11/lib/python3.11/site-packages/pip/_internal/cli/base_command.py", line 223, in _main
    self.handle_pip_version_check(options)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/runner/Library/Caches/pypoetry/virtualenvs/python-miio-T8lMymkM-py3.11/lib/python3.11/site-packages/pip/_internal/cli/req_command.py", line 144, in handle_pip_version_check
    session = self._build_session(
              ^^^^^^^^^^^^^^^^^^^^
  File "/Users/runner/Library/Caches/pypoetry/virtualenvs/python-miio-T8lMymkM-py3.11/lib/python3.11/site-packages/pip/_internal/cli/req_command.py", line 89, in _build_session
    session = PipSession(
              ^^^^^^^^^^^
  File "/Users/runner/Library/Caches/pypoetry/virtualenvs/python-miio-T8lMymkM-py3.11/lib/python3.11/site-packages/pip/_internal/network/session.py", line 282, in __init__
    self.headers["User-Agent"] = user_agent()
                                 ^^^^^^^^^^^^
  File "/Users/runner/Library/Caches/pypoetry/virtualenvs/python-miio-T8lMymkM-py3.11/lib/python3.11/site-packages/pip/_internal/network/session.py", line 157, in user_agent
    setuptools_dist = get_default_environment().get_distribution("setuptools")
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/runner/Library/Caches/pypoetry/virtualenvs/python-miio-T8lMymkM-py3.11/lib/python3.11/site-packages/pip/_internal/metadata/importlib/_envs.py", line 163, in get_distribution
    return next(matches, None)
           ^^^^^^^^^^^^^^^^^^^
  File "/Users/runner/Library/Caches/pypoetry/virtualenvs/python-miio-T8lMymkM-py3.11/lib/python3.11/site-packages/pip/_internal/metadata/importlib/_envs.py", line 158, in <genexpr>
    matches = (
              ^
  File "/Users/runner/Library/Caches/pypoetry/virtualenvs/python-miio-T8lMymkM-py3.11/lib/python3.11/site-packages/pip/_internal/metadata/base.py", line 485, in iter_all_distributions
    for dist in self._iter_distributions():
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/runner/Library/Caches/pypoetry/virtualenvs/python-miio-T8lMymkM-py3.11/lib/python3.11/site-packages/pip/_internal/metadata/importlib/_envs.py", line 150, in _iter_distributions
    yield from finder.find(location)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/runner/Library/Caches/pypoetry/virtualenvs/python-miio-T8lMymkM-py3.11/lib/python3.11/site-packages/pip/_internal/metadata/importlib/_envs.py", line 54, in find
    for dist, info_location in self._find_impl(location):
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/runner/Library/Caches/pypoetry/virtualenvs/python-miio-T8lMymkM-py3.11/lib/python3.11/site-packages/pip/_internal/metadata/importlib/_envs.py", line 42, in _find_impl
    normalized_name = canonicalize_name(get_dist_name(dist))
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/runner/Library/Caches/pypoetry/virtualenvs/python-miio-T8lMymkM-py3.11/lib/python3.11/site-packages/pip/_vendor/packaging/utils.py", line 34, in canonicalize_name
    value = _canonicalize_regex.sub("-", name).lower()
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: expected string or bytes-like object, got 'NoneType'

@rytilahti rytilahti changed the title Disable 3.11-dev builds on windows and mac targets Disable fail-fast on CI tests Jul 8, 2022
@rytilahti rytilahti force-pushed the janitor/disable_py311_win_osx branch from 01160f7 to dfbcc3e Compare July 8, 2022 14:44
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2022

Codecov Report

Merging #1450 (be4f997) into master (74b6b42) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head be4f997 differs from pull request most recent head dfbcc3e. Consider uploading reports for the commit dfbcc3e to get more accurate results

@@            Coverage Diff             @@
##           master    #1450      +/-   ##
==========================================
+ Coverage   84.18%   84.19%   +0.01%     
==========================================
  Files         135      135              
  Lines       13448    13449       +1     
  Branches     1499     3216    +1717     
==========================================
+ Hits        11321    11324       +3     
+ Misses       1909     1907       -2     
  Partials      218      218              
Impacted Files Coverage Δ
miio/integrations/vacuum/roborock/vacuum.py 64.67% <0.00%> (+0.06%) ⬆️
miio/integrations/vacuum/roborock/vacuum_tui.py 32.09% <0.00%> (+2.46%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@rytilahti rytilahti merged commit 04a9999 into master Jul 8, 2022
@rytilahti rytilahti deleted the janitor/disable_py311_win_osx branch July 8, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants