Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zhimi_miot: Rename fan_speed to speed #1439

Merged
merged 3 commits into from
Jun 19, 2022

Conversation

syssi
Copy link
Collaborator

@syssi syssi commented Jun 19, 2022

@syssi syssi requested a review from rytilahti June 19, 2022 05:53
@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2022

Codecov Report

Merging #1439 (f7c170c) into master (85e30f6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1439   +/-   ##
=======================================
  Coverage   84.29%   84.30%           
=======================================
  Files         135      135           
  Lines       13393    13401    +8     
  Branches     3200     3204    +4     
=======================================
+ Hits        11290    11298    +8     
  Misses       1886     1886           
  Partials      217      217           
Impacted Files Coverage Δ
miio/integrations/fan/zhimi/test_zhimi_miot.py 98.11% <100.00%> (+0.05%) ⬆️
miio/integrations/fan/zhimi/zhimi_miot.py 82.70% <100.00%> (+0.67%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants