Skip to content

Do not use deprecated depth property #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rytilahti merged 2 commits into from
Aug 31, 2021
Merged

Do not use deprecated depth property #1124

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc7e8e0
Do not use deprecated depth property
bieniu Aug 30, 2021
ea5262c
Use local variable
bieniu Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions miio/airhumidifier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,9 @@ def water_level(self) -> Optional[int]:

If water tank is full, depth is 125.
"""
if self.depth is not None and self.depth <= 125:
return int(self.depth / 1.25)
depth = self.data.get("depth")
if depth is not None and depth <= 125:
return int(depth / 1.25)
return None

@property
Expand Down