Fixed lint errors. Made CI run on PRs (#27)

* Fixed lint errors. Made CI run on PRs

* Adjusting CI trigger

* Changes to README

Author: ryanrolds

.github/workflows/ci.yaml

@@ -1,9 +1,12 @@
 name: build
 on:
   push:
+    branches:
+      - main
+  pull_request:
 jobs:
   golangci:
-    name: lint
+    name: CI
     runs-on: ubuntu-latest
     steps:
       - uses: actions/setup-go@v3

README.md

@@ -1,7 +1,7 @@
 # sqlclosecheck
 
 Linter that checks if SQL rows/statements are closed. Unclosed rows and statements may
-cause DB connection pool exhaustion.
+cause DB connection pool exhaustion. Included in `golangci-lint` as `sqlclosecheck`.
 
 ## Running
 
@@ -15,9 +15,18 @@ In your project directory:
 go vet -vettool=$(which sqlclosecheck) ./...
 ```
 
-## CI
+## Developers
+
+Start by creating a test that should pass/fail.
+Test are located at `pkg/analyzer/testdata`. 
+All PRs that modify the analyzer should include a test.
+Negative tests are just as important as positive tests.
 
+Make changes to the analyzer (`pkg/analyzer`) and run the tests:
 ```
-go install github.com/ryanrolds/sqlclosecheck@latest
-go vet -vettool=${GOPATH}/bin/sqlclosecheck ./...
+make test
 ```
+
+## CI
+
+GitHub Actions that runs on push to `main` and PRs.

pkg/analyzer/analyzer.go

@@ -2,6 +2,7 @@ package analyzer
 
 import (
 	"go/types"
+
 	"golang.org/x/tools/go/analysis"
 	"golang.org/x/tools/go/analysis/passes/buildssa"
 	"golang.org/x/tools/go/ssa"
@@ -171,11 +172,11 @@ func getTargetTypesValues(b *ssa.BasicBlock, i int, targetTypes []any) []targetV
 		for _, targetType := range targetTypes {
 			var tt types.Type
 
-			switch targetType.(type) {
+			switch t := targetType.(type) {
 			case *types.Pointer:
-				tt = targetType.(*types.Pointer)
+				tt = t
 			case *types.Named:
-				tt = targetType.(*types.Named)
+				tt = t
 			default:
 				continue
 			}
@@ -297,11 +298,11 @@ func getAction(instr ssa.Instruction, targetTypes []any) action {
 		for _, targetType := range targetTypes {
 			var tt types.Type
 
-			switch targetType.(type) {
+			switch t := targetType.(type) {
 			case *types.Pointer:
-				tt = targetType.(*types.Pointer)
+				tt = t
 			case *types.Named:
-				tt = targetType.(*types.Named)
+				tt = t
 			default:
 				continue
 			}
@@ -361,11 +362,11 @@ func checkDeferred(pass *analysis.Pass, instrs *[]ssa.Instruction, targetTypes [
 			for _, targetType := range targetTypes {
 				var tt types.Type
 
-				switch targetType.(type) {
+				switch t := targetType.(type) {
 				case *types.Pointer:
-					tt = targetType.(*types.Pointer)
+					tt = t
 				case *types.Named:
-					tt = targetType.(*types.Named)
+					tt = t
 				default:
 					continue
 				}