font-patcher: Warn if sourcefont is a VF #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finii
force-pushed
the
feature/detect-VF
branch
2 times, most recently
from
4871ea6
to
fe2bfed
Compare
|
Fixed in #961 |
Finii
force-pushed
the
feature/detect-VF
branch
from
fe2bfed
to
610af2a
Compare
[why] fontforge is not really able to work with OpenType variable fonts, at least not with all. Some support is available as MM, for older formats. But anyhow we do not really create a patched variable font but a fixed font. People might ignore all the errors Fontforge throws on opening, so an explicit message might be in order. [how] It is not possible to detect a VF input font with current fontforge reliably. Instead we search for the existence of one of the tables that are needed for a variable font. We can not rely on STAT, because that might be also used in fixed fonts. Some fontforges might crash on VFs, so we give a warning before we even open the font and one after the patched font has been created. Fixes: #512 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
force-pushed
the
feature/detect-VF
branch
from
610af2a
to
41e693a
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
fontforge is not really able to work with OpenType variable fonts, at least not with all. Some support is available as MM, for older formats. But anyhow we do not really create a patched variable font but a fixed font.
People might ignore all the errors Fontforge throws on opening, so an explicit message might be in order.
[how]
It is not possible to detect a VF input font with current fontforge reliably. Instead we search for the existence of one of the tables that are needed for a variable font. We can not rely on
STAT, because that might be also used in fixed fonts.Fixes: 512
Requirements / Checklist
What does this Pull Request (PR) do?
Just add a warning when trying to patch a VF.
How should this be manually tested?
Patch a normal (static) font, patch a VF font.
Any background context you can provide?
What are the relevant tickets (if any)?
#512
Screenshots (if appropriate or helpful)