install.sh --remove #822
Merged
install.sh --remove #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finii
commented
Apr 22, 2022
Finii
force-pushed
the
feature/install-remove
branch
from
9a749aa
to
0213c9b
Compare
|
Removed debug-output; force push. |
[why] We have only 'Complete' in the repo anymore, so it does not make sense to provide commands to select un-complete patched fonts. [how] Leave stub/comment in so that - if there ever is a need to resurrect the feature - one can find this commit and the deleted code. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] Maybe people would like to uninstall the fonts installed with the script. In fact the uninstall could already be acieved by giving the --clean option and installing no new font. Well, apart from the fact that the scripts prevents runs with no installed font. And then the user must specify the same installpath that has been used for the install, which is a bit tedious. [how] Add new command '--remove' (with no short option). Make -L / --list option a dry-run option for --remove. Uninstall both possible installpaths. Fixes: #407 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
force-pushed
the
feature/install-remove
branch
from
0213c9b
to
6ccbc7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is about the
install.shscriptRequirements / Checklist
What does this Pull Request (PR) do?
Add uninstall possibility to install script.
How should this be manually tested?
One can specify
--remove -Lfor a dry run to see the commands that would be executed.Any background context you can provide?
What are the relevant tickets (if any)?
#407
Screenshots (if appropriate or helpful)