-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Victor Mono in Windows Terminal: some characters are very small #1080
Comments
I fear the family naming is the problem. Can you remove as many
If that is the cause we can (easily) fix it. It's important to test with just these 4 fonts (or the 4 |
Thanks for reporting @A-Lamia ! Unfortunately in your very constructive critique you do not explain what the concrete issue is. Maybe you mean the circled glyph that renders 1 cell wide in 2.3.3 and 2 cell wide in 2.3.0-RC. Which can mean that you think 2.3.0-RC is not broken, while 2.3.3 is broken, in that regard. Without any explanation it is hard to offer any help. Anyhow, if it is about the powerline glyphs, they will be resized with 3.0.0: |
I have the same problem with Windows Terminal. The biggest problem are "g" that looks like "q" at some sizes, and "_" which... dissappears completely, looking like space. Everything is ok with original Victor Mono font. |
@rzabcio To make it easier for me to reproduce: Where did you get the font files from, and did you install just one, some, or 'all' (whatever that means)? |
I tried two sources, with the same effect.
(my main OS is Windows, but I work on VM through ssh on Windows Terminal) I tried Windows Compatible version. |
Did install this set of 4 on Windows 10: Setting this up in Terminal: And the result is ok (i.e. can not reproduce): Italic was a bit harder ... ;-) But what I noticed, that all the letters that seem to be affected in your setup are the ones that are cut off: This could be an effect of Windows Terminal, because it scales too-big glyphs down. I have Anyhow, I guess the cut-off problem is solved with |
Maybe I'm too old 😬 but I think I do not understand that. I guess you installed the Arch package in the VM. But the Windows Terminal runs under Windows, so how does the fonts leak out of the VM into the host OS 🤔 It's probably not a VM but this ominous Windows Linux Subsystem or how that is called. If you install a font in that Linux subsystem it will end up in the Windows font folder? 😬 |
Nope, that is not how WSL works. Installing fonts in a WSL distro should have zero effect on the available fonts in Windows. It should have an effect on graphical Linux apps running via WSLg, but that's not the point here. |
You are right, obviously, I just maden a huge shortcut i my description. I use Arch on VMWare Workstation. I installed there above Arch package, found .ttf fonts in the filesystem, zipped them, scp-d them from the host Windows, installed it normally and finally selected it in Windows Terminal. That's the full path, sorry for unclear comment. :-) |
Release is in repo, release as packages pending. |
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
🗹 Requirements
🎯 Subject of the issue
I have downloaded the Victor Mono zip file the v2.3.3 release and tried to use it in Windows Terminal, which almost works, but a few characters are rendered very small.
Experienced behavior:
Some letters are rendered way smaller than the rest for most font sizes. See screenshots below. I've noticed "fi" (ligature) and "g" (regular) in the italic "config" (for the non-italic, it's just the "g"). It also happens for "y". Some font-sizes are fine, e.g. 12 points and 16 points, but those are either too small or too large for my setup to be useable. The regular Victor Mono renders everything fine for e.g. 14 points (which is what I would like to use mostly).
Expected behavior:
All characters should be rendered in the correct font size.
Example symbols:
🔧 Your Setup
Anonymice Powerline Nerd Font Complete.ttf
)?iterm2
,urxvt
,gnome
,konsole
)?★ Screenshots (Optional)
Regular Victor Mono renders everything just fine, but of course the Nerd Font icons are missing.
"VictorMono NF" and "VictorMono NFM" seem to be exactly the same, "VictorMono Nerd Font" is even worse, the whole italics are not working for that one.
I've tried to install both the "Windows Compatible" variants, and the "regular" ones. I had no luck with both. :-(
The text was updated successfully, but these errors were encountered: