-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menu Item Order #3
Comments
@awcodes I can't seem to reproduce this problem.. can you record a video and also send over your model configuration? |
The model is the one in the package, i'm not doing anything with it outside of the package. menu-order.mov |
What database are you using? |
MySQL 5.7 Looks like the issue is related to this https://dev.mysql.com/doc/refman/5.7/en/json.html#json-comparison |
I have verified that the package is maintaining the correct order before saving, so this is definitely a database issue with JSON columns, and not an issue with the plugin itself. |
Works perfectly with a longText column and an array cast, but i'm sure you have a reason for using the JSON column. I'll go ahead and close this, but maybe a note in the Readme would help others in the future. Thanks for your feedback and patience. |
Ah, interesting... perhaps I'll move to use a longText then for compatibility reasons... |
@awcodes I've just released v0.2.0 with a fix for this (changing column to longText), you'll need to run a You should also publish the assets again and clear your view cache to get the latest CSS changes from your dark mode PR. Thanks! |
@ryangjchandler Awesome. Thanks again for all you do. |
Not sure if this is an issue just on my machine or not, but when saving a menu it appears that the UUID is causing the JSON column to default sort the menu items in ascending order (for indexing purposes, I believe). This prevents the menu item order from being preserved.
This can be seen by saving a menu then just refreshing the page.
The text was updated successfully, but these errors were encountered: