Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RecLayer time dim explicit instead of implicit via RecUnstackLayer #72

Closed
albertz opened this issue Nov 9, 2021 · 1 comment
Closed

RecLayer time dim explicit instead of implicit via RecUnstackLayer #72

albertz opened this issue Nov 9, 2021 · 1 comment
Milestone
first-release

Comments

@albertz
Copy link
Member

albertz commented Nov 9, 2021 •
edited
Loading

This would be cleaner and more robust.

Also, on RETURNN side, maybe we should change the side effect in RecUnstackLayer of mark_same_time and instead just assert that it is the same already (rwth-i6/returnn#750).
@albertz albertz added this to the first-release milestone Nov 9, 2021
@albertz albertz mentioned this issue Nov 9, 2021
Open
@albertz
Copy link
Member Author

albertz commented Nov 12, 2021

Done now, via Loop.unstack() and the axis option to Loop().

@albertz albertz closed this as completed Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
first-release
Development

No branches or pull requests
1 participant
@albertz