Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out spatial dim tags arguments not needed #115

Closed
albertz opened this issue Feb 18, 2022 · 1 comment
Closed

Out spatial dim tags arguments not needed #115

albertz opened this issue Feb 18, 2022 · 1 comment
Assignees
Milestone

Comments

@albertz
Copy link
Member

albertz commented Feb 18, 2022

#17 (comment) lead us to have out_spatial_dim as an optional arg to many functions and modules, e.g. Conv.

Maybe actually passing this is never really needed. If the user wants to verify that the resulting out spatial dim tag is as expected, he simply can do sth like:

conv = Conv1d(...)
out, out_spatial_dim = conv(...)
assert out_spatial_dim...  # whatever

This applies for many functions and modules which can be cleaned up then.

@albertz
Copy link
Member Author

albertz commented Mar 3, 2022

This is mostly cleaned up now.

@albertz albertz closed this as completed Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants