Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment fault on memory exhaustion. Should error out instead. #24

Open
paoloczi opened this issue Nov 13, 2019 · 1 comment
Open

Segment fault on memory exhaustion. Should error out instead. #24

paoloczi opened this issue Nov 13, 2019 · 1 comment

Comments

@paoloczi
Copy link

Spoa segment faults if it runs out of memory. Instead, it should throw an exception or return an error code. The attached test program segment faulted on my 32 GB laptop. I realize sequences these long are outside of what spoa can reasonably do, but a segment fault is not an acceptable termination mode, because client code does not get a chance to write a meaningful message for the end user.

testSpoa.cpp.gz

@paoloczi paoloczi changed the title Segment fault on memory exception. Should error our instead. Segment fault on memory exception. Should error out instead. Nov 14, 2019
@rvaser
Copy link
Owner

rvaser commented Nov 15, 2019

Hi Paolo,
I'll fix this as soon as possible.

Best regards,
Robert

@paoloczi paoloczi changed the title Segment fault on memory exception. Should error out instead. Segment fault on memory exhaustion. Should error out instead. Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants