Repository navigation
fix(sdk): declare supported ESPHome, spectrum and LiDAR arguments - #2225
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public SDK already accepts ESPHome radar, spectrum collection options and the iPhone frame limit, but its TypeScript declarations reject valid callers. Align declarations with supported runtime options and retain checks that reject invalid options.
The upstream strict TypeScript consumer has four TS2353 errors for valid workflows. The fixed exact-commit consumer compiles with TypeScript5.9.3 and expected-error controls. Six runtime tests and all eight harness gates pass; independent strict compilation and three actual TCP/UDP/WebSocket SDK producer tests pass. Includes ADR409 and regenerated manifest. Protocol fixtures establish option forwarding, not physical sensor accuracy. Hosted checks may require maintainer approval.