You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I started moving the tutorial over to the Rust WebAssembly template and I'm struggling to follow the instructions from the Sending pull requests section in the readme.
The described steps are more involved than your typical git workflow. But they are written in an ambiguous way and it feels like unless you are a git wizard you won't be able to figure out what to do.
For example the first step tells us to "checkout the branch for the first chapter that needs to be updated". But I never used git checkout to go to the chapter I wanted and cloning the repository using the provided command don't create any branches. I just cded into the corresponding folder since they are submodules and I guess it did the trick.
Since we are dealing with advanced git concepts here I'm not sure it would be an easy task to improve this section. However I think that giving commands which can be copy-pasted is a good starting point, even if the explanations aren't that great.
I will try to report the commands I used to be able to get to the point where I can send my changes when I'll be finished working on my current issue.
I hope the point I'm trying to raise is clear!
The text was updated successfully, but these errors were encountered:
Hey @nanoplink, yeah they are ambiguous as we've talked about. I'm going to write up some more detailed instructions here for you later today so you know how to do it. I'll make a note in the future to make sure we clarify instructions more so that even new contributors can tackle issues. git is tough and more advance workflows are alien if you've not done it before :/
Then cd into each directory to make changes for each chapter. Then commit in each chapter what you want to change. Then when ready go to the top level on master and add all the chapters and make a commit. Then push that to your branch and open up a PR.
I started moving the tutorial over to the Rust WebAssembly template and I'm struggling to follow the instructions from the Sending pull requests section in the readme.
The described steps are more involved than your typical git workflow. But they are written in an ambiguous way and it feels like unless you are a git wizard you won't be able to figure out what to do.
For example the first step tells us to "checkout the branch for the first chapter that needs to be updated". But I never used
git checkout
to go to the chapter I wanted and cloning the repository using the provided command don't create any branches. I just cded into the corresponding folder since they are submodules and I guess it did the trick.Since we are dealing with advanced git concepts here I'm not sure it would be an easy task to improve this section. However I think that giving commands which can be copy-pasted is a good starting point, even if the explanations aren't that great.
I will try to report the commands I used to be able to get to the point where I can send my changes when I'll be finished working on my current issue.
I hope the point I'm trying to raise is clear!
The text was updated successfully, but these errors were encountered: