Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run specific tests during wasm-pack test #630

Merged
merged 1 commit into from
Apr 19, 2019

Conversation

alexcrichton
Copy link
Contributor

This builds on rustwasm/wasm-bindgen#1465 by ensuring that wasm-pack test --node will now only test node.js tests

Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me! can we update the documentation to make sure this is clear to folks?

@ashleygwilliams ashleygwilliams added this to the 0.9.0 milestone Apr 18, 2019
@ashleygwilliams ashleygwilliams added changelog - feature needs docs please add docs to this PR labels Apr 18, 2019
This builds on rustwasm/wasm-bindgen#1465 by ensuring that `wasm-pack
test --node` will now only test node.js tests
@alexcrichton
Copy link
Contributor Author

In a sense this is actually a bugfix to update to what the CLI flags actually mean (when you pass --node only running Node tests), so I think the documentation largely already made sense but I tweaked a bit to make sure this is explicitly mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants