Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete template deep dives #490

Merged
merged 3 commits into from
Jan 13, 2019
Merged

Complete template deep dives #490

merged 3 commits into from
Jan 13, 2019

Conversation

danwilhelm
Copy link
Member

Closes issues #345, #346 by adding deep dives for src/lib.rs and src/utils.rs. Also updates original deep dive text to latest template.

Tested using mdbook build.

  • [✅] You have the latest version of rustfmt installed
  • [✅] You ran cargo fmt on the code base before submitting
  • [✅] You reference which issue is being closed in the PR text

@danwilhelm danwilhelm changed the title Complete template deep dive section Complete template deep dives Jan 13, 2019
ashleygwilliams
ashleygwilliams approved these changes Jan 13, 2019
View reviewed changes
Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is super amazing! thank you so much for this!

@ashleygwilliams ashleygwilliams added this to the 0.6.0 milestone Jan 13, 2019
@ashleygwilliams ashleygwilliams merged commit ea99a2d into rustwasm:master Jan 13, 2019
@danwilhelm danwilhelm deleted the template_deep_dive branch January 13, 2019 22:15
This was referenced Jan 15, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleygwilliams ashleygwilliams ashleygwilliams approved these changes

Assignees
No one assigned
Labels
changelog - docs
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@danwilhelm @ashleygwilliams