Replace internal Error with failure::Error
#436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
approved these changes
Nov 6, 2018
src/child.rs
Outdated
| for line in stdout.lines() { | ||
| msg.push_str(" "); | ||
| msg.push_str(line); | ||
| msg.push_str("\n"); |
There was a problem hiding this comment.
This is going to re-create the double-output thing, since the output is already re-printed as the command is run.
This commit removes the internal `Error` type in favor of exclusively using the `failure::Error` type, simplifying error construction in a number of locations and reducing the number of error types in play.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the internal
Errortype in favor of exclusivelyusing the
failure::Errortype, simplifying error construction in anumber of locations and reducing the number of error types in play.